![]() | ||||||||||
Messages in this thread |
On Wed, Jan 02 2002, Douglas Gilbert wrote: > Peter Osterlund <petero2@telia.com> wrote: > > > Jens Axboe <axboe@suse.de> writes: > > > > > On Wed, Jan 02 2002, Peter Osterlund wrote: > > > > Hi! > > > > > > > > While doing some stress testing on the 2.5.2-pre5 kernel, I am hitting > > > > a kernel BUG at scsi_merge.c:83, followed by a kernel panic. The > > > > problem is that scsi_alloc_sgtable fails because the request contains > > > > too many physical segments. I think this patch is the correct fix: > > > > > > Correct, ll_rw_blk default is ok now. I missed this when killing > > > scsi_malloc/scsi_dma, thanks. > > > > It turns out this is still not enough to fix the problem for me, > > because ll_new_hw_segment is still allowing nr_phys_segments to become > > too large. Is the following patch the correct way to deal with this > > problem, or is that case supposed to be prevented by some other means? > > At least, this patch prevents the kernel panic during my stress test. > > <snipped patches/> > > Peter, > I was able to get a repeatable oops at that line copying > files from /boot onto a "fake" scsi_debug disk with "pre5". > The first largish file it attempted to copy caused the > oops (which I sent to Jens). > > Anyway, I just applied your 2 patches (to scsi.c and ll_rw_blk.c) > and the oops is no more. I've included a slightly modified version, your logic was correct though Peter. Thanks. -- Jens Axboe - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | |||||||||
| Last update: 2005-03-22 12:15 [W:0.213 / U:0.490 seconds] ©2003-2008 Jasper Spaans | ||||||||||