Messages in this thread | | | Date | Sun, 27 Jan 2002 14:42:13 +1100 | From | Rusty Russell <> | Subject | Re: [RFC] Peeling off dcache_lock |
| |
On Fri, 25 Jan 2002 11:44:11 +0530 Maneesh Soni <maneesh@in.ibm.com> wrote:
> On Thu, Jan 24, 2002 at 06:02:41PM +1100, Rusty Russell wrote: > > Hi Maneesh! > > > > Fantastic work! A couple of questions, and a trivial patch: > > Hi Rusty, > > Thanks for code review.
Hey, anything that wins 20% on (32-way) dbench is worth reading 8)
> > o Am I correct in asserting that you could change all the > > "list_empty(dentry->dhash)" tests to > > "dentry->d_vfs_flags & DCACHE_DEFERRED_FREE" tests, and hence change the > > list_del_init() to list_del() in unhash, and thus remove the d_nexthash > > field altogether? > I agree that d_next_hash is a sort of hack and want to remove it. I think > we have tried removing it in the way you are suggesting. But we never got a > stable code. I will have to look at this some what more.
Hmm... I finally have a dual x86 box here, so I can play with this as well.
> > o d_lookup looks like it can return an DCACHE_DEFERRED_FREE dentry: this > > seems wrong: shouldn't it loop here? > Actually d_lookup will fail if the found dentry has DCACHE_DEFERRED_FREE set.
ACK. Sorry, my mistake.
> I will do all these corrections in the next version very soon.
I wouldn't say "corrections": your code is very nice. I'm looking forward to your next iteration!
> > Any chance of you making it to http://linux.conf.au next month BTW? > Probably not as I am getting married next month ;-) and lots of shopping is > still remaining ;-).
Oh, congratulations! Perhaps I shall have to find a conference in India then 8)
Thanks! Rusty. -- Anyone who quotes me in their sig is an idiot. -- Rusty Russell. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |