![]() | |||||||||||||
Messages in this thread |
On Jan 25, 2002 23:15 +0100, Andi Kleen wrote: > On Fri, Jan 25, 2002 at 01:38:14PM -0700, Andreas Dilger wrote: > > When calling kmem_cache_destroy() on a non-empty slab we should just > > malloc some memory with the old cache name + "_leaked" for the name > > pointer. At least then we have a sane chance of figuring out what caused > > the problem, instead of having a bunch of "broken" entries in the table, > > and remove the above "broken" check entirely (we will always have a name). > > I don't like this because it complicates the code too much. > "broken" should be enough to debug it. Hmm, then you could just point to a static "broken" name at kmem_cache_destroy() time and save yourself the get_user() checks for each access to the name. This would gratuitously overwrite the name for non-modular caches that failed to unload, but I doubt that such things exist. Cheers, Andreas -- Andreas Dilger http://sourceforge.net/projects/ext2resize/ http://www-mddsp.enel.ucalgary.ca/People/adilger/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | ||||||||||||
| Last update: 2005-03-22 12:15 [W:0.362 / U:0.050 seconds] ©2003-2008 Jasper Spaans | |||||||||||||