lkml.org 
[lkml]   [2002]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: Linux 2.4.18-pre4


On Wed, 16 Jan 2002, Ingo Oeser wrote:

> [1]
> + do {
> + block_end = block_start+blocksize;
> + if (block_end <= from)
> + continue;
> [2]
>
> The situation between [1] and [2] won't change, so I don't
> understand the "continue" here and think it will either never be
> triggered or an endless loop.
>
> Could you or the one introducing this clarify?

Lovely... Thanks for spotting.
--- fs/buffer.c Wed Jan 16 04:39:56 2002
+++ fs/buffer.c.new Wed Jan 16 04:43:29 2002
@@ -1686,7 +1686,7 @@
do {
block_end = block_start+blocksize;
if (block_end <= from)
- continue;
+ goto skip_it;
if (block_start >= to)
break;
if (buffer_new(bh)) {
@@ -1696,6 +1696,7 @@
set_bit(BH_Uptodate, &bh->b_state);
mark_buffer_dirty(bh);
}
+ skip_it:
block_start = block_end;
bh = bh->b_this_page;
} while (bh != head);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:18    [from the cache]
©2003-2011 Jasper Spaans. Advertise on this site