[lkml]   [2002]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] Compilation error on 2.5.10 linux-2.5/drivers/ide/pdc4030.c
    >This fixes an error when compiling and removes a unused variable warning
    >The following warning I'm not sure about though:
    >pdc4030.c: In function `do_pdc4030_io':
    >pdc4030.c:571: warning: control reaches end of non-void function

    That warning is because the function returns an ide_startstop_t but there
    is no ending return statement. Looking at the code it is possible to
    reach that particular code path. Mind doing a quick patch?

    ide_startstop_t do_pdc4030_io (ide_drive_t *drive, struct request *rq)
    printk(KERN_ERR "pdc4030: command not READ or WRITE!
    ide_end_request(0, HWGROUP(drive));
    <=== [1]

    [1] No return statement here but function is non-void (ie it should return

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2005-03-22 13:18    [W:0.034 / U:34.368 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site