[lkml]   [2001]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [patch] softirq performance fixes, cleanups, 2.4.10.

    On Fri, 28 Sep 2001, Andrea Arcangeli wrote:

    > he's allowing to repeat the loop more than once to hide it, [...]

    it's not done to 'hide' it in any way. I removed the mask method because
    it's redundant under the new scheme.

    Softirqs *cannot* be handled 'fairly', there is always going to be one
    that is called sooner, and one that is called later, and even with the old
    code, their position within the bitmask decides which one goes first.

    > to do the "mask" with repetition correctly we'd need a per-softirq
    > counter, not just a bitmask so it wouldn't be handy to allocate on the
    > stack, but it's nothing unfixable.

    with a repetition count of 10, there is no difference, and no reason to
    add the mask mechanizm again. (In fact it will statistically more fair
    because we 'interleave' the softirqs in a fair pattern.)

    to make it easier to compare, here are verbal descriptions of the two
    mechanizms. (for those who have *cough* trouble understanding the patch.)

    the old code's "mask method": it starts processing softirqs in strict
    order. It will reprocess any softirq (in strict order again) that got
    reactivated meanwhile, but it will only process softirqs that were not
    processed yet during this run.

    it's not roundrobin, and it's not fair in any way, there is a strict
    priority between softirqs, with the additional twist of processing
    softirqs that got activated meanwhile. This concept is completely
    meaningless, it neither tries to process all pending softirqs, nor does it
    try implement some simple policy, like 'process all softirqs that are
    active *now* and *once*'.

    the new method does a simple loop (in priority order, first HI, then TX,
    then RX and LO) over all currently active softirqs, then it does a
    (limited) loop over all of them again if some softirq got activated while
    these were processed.


    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2005-03-22 13:03    [W:0.021 / U:2.988 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site