lkml.org 
[lkml]   [2001]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH] 2.4.9-ac12 - problem mounting reiserfs (parse error?)
Hello!

> But in my case I don't have "defaults" on fstab on my reiserfs partitions:
>
> /dev/hdc1 / ext2 defaults,errors=remount-ro 0 1
> /dev/hdc5 /home reiserfs rw 0 2

The common part is that you only have options recognized before they come
to the reiserfs level. So the option list is empty at this point, with
reiserfs cannot deal with it.

Here's the fix for 2.4.9-ac12:

---------------------------------
--- linux.orig/fs/reiserfs/super.c
+++ linux/fs/reiserfs/super.c
@@ -223,7 +223,7 @@ static int parse_options (
{"0", 0}
};
*blocks = 0;
- if (!options)
+ if (!options || !*options)
/* use default configuration: create tails, journaling on, no
conversion to newest format */
return 1;
---------------------------------
If the string is empty, there is nothing to parse in it. Another question
is that the parser could be made more robust, but my patch is correct,
minimal and works for me.

> > "reiserfs kgetopt: there is not option" appears on the console and in the
> > dmesg output, it's not coming from mount.

To reiserfs team: please check spelling. It should be "there is no
option". Also there are "pounters" in the comments.

--
Regards,
Pavel Roskin

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:03    [W:0.988 / U:0.036 seconds]
©2003-2014 Jasper Spaans. Advertise on this site