lkml.org 
[lkml]   [2001]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] avoid unnecessary cache flushes
From
   From: Paul Mackerras <paulus@samba.org>
Date: Fri, 31 Aug 2001 21:18:50 +1000 (EST)

Any comments from the architecture maintainers? Linus, does this look
OK to apply to your tree?

No comments other than it will silently break sparc64 as you've
updated the declarations in the asm-sparc64 headers but failed to
fixup the assembler routine itself to expect the page * arg.

I would suggest instead to change the name of the assembler
routine to __copy_user_page et al. and make copy_user_page just
an inline or define which plucks out page->address and passes
that onto __copy_user_page. This way you require no knowledge
of Sparc assembly whatsoever.

Later,
David S. Miller
davem@redhat.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:01    [W:0.100 / U:0.752 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site