lkml.org 
[lkml]   [2001]   [Aug]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [IDEA+RFC] Possible solution for min()/max() war
    Date
    From
    > >	min(host->scsi.SCp.this_residual, DMAC_BUFFER_SIZE / 2);
    >
    > >this_residual is "int", and "DMAC_BUFFER_SIZE" is just a #define for
    > >an integer constant. So the above is actually a signed comparison, and
    > >I'll bet you that was not what the author intended.
    >
    > And the mistake of the author was not to write "unsigned int this_residual".
    > That's the bug. Not the min() function.

    Or more likely the author knew that this_residual was going to be positive
    in all cases anyway. Its just sloppy typing by the scsi layer.

    The typing of min() is something I do agree with Linus about (for once 8)),
    and making people think about them is a good idea. When DaveM proposed the
    original his patches showed up a bug in the older ixj driver immediately.

    Alan

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 12:58    [W:0.021 / U:30.840 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site