lkml.org 
[lkml]   [2001]   [Aug]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patches in this message
    /
    Date
    SubjectRe: linux-2.4.9: atomic_dec_and_lock sometimes used while not defined
    From
    >>>>> " " == Christoph Hellwig <hch@ns.caldera.de> writes:

    > Hi Trond, In article <shsu1z7c7qa.fsf@charged.uio.no> you
    > wrote:
    >> diff -u --recursive --new-file linux-2.4.9.orig/lib/Makefile
    >> linux-2.4.9/lib/Makefile
    >> --- linux-2.4.9.orig/lib/Makefile Wed Apr 25 22:31:03 2001
    >> +++ linux-2.4.9/lib/Makefile Fri Aug 17 11:52:35 2001
    >> @@ -16,6 +16,7 @@ obj-$(CONFIG_RWSEM_XCHGADD_ALGORITHM) +=
    >> rwsem.o
    >>
    >> ifneq ($(CONFIG_HAVE_DEC_LOCK),y)
    >> + export-objs += dec_and_lock.o
    >> obj-y += dec_and_lock.o endif
    > Nonono! Please add it to export-objs _always_ not dependand on
    > some CONFIG_ symbol, that's how the 2.4 makefiles work.
    Revised patch follows...

    Cheers,
    Trond

    diff -u --recursive --new-file linux-2.4.9/lib/Makefile linux-2.4.9-atomic_lock/lib/Makefile
    --- linux-2.4.9/lib/Makefile Wed Apr 25 22:31:03 2001
    +++ linux-2.4.9-atomic_lock/lib/Makefile Fri Aug 17 12:38:24 2001
    @@ -8,7 +8,7 @@

    L_TARGET := lib.a

    -export-objs := cmdline.o rwsem-spinlock.o rwsem.o
    +export-objs := cmdline.o dec_and_lock.o rwsem-spinlock.o rwsem.o

    obj-y := errno.o ctype.o string.o vsprintf.o brlock.o cmdline.o

    diff -u --recursive --new-file linux-2.4.9/lib/dec_and_lock.c linux-2.4.9-atomic_lock/lib/dec_and_lock.c
    --- linux-2.4.9/lib/dec_and_lock.c Sat Jul 8 01:22:48 2000
    +++ linux-2.4.9-atomic_lock/lib/dec_and_lock.c Fri Aug 17 12:22:49 2001
    @@ -1,3 +1,4 @@
    +#include <linux/module.h>
    #include <linux/spinlock.h>
    #include <asm/atomic.h>

    @@ -34,4 +35,6 @@
    spin_unlock(lock);
    return 0;
    }
    +
    +EXPORT_SYMBOL(atomic_dec_and_lock);
    #endif
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2005-03-22 12:57    [W:0.037 / U:2.024 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site