[lkml]   [2001]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] copy_from_high_bh
    On Sun, Jul 08, 2001 at 07:26:01PM +0100, Mark Hemment wrote:
    > On Sun, 8 Jul 2001, Linus Torvalds wrote:
    > > On Sun, 8 Jul 2001 wrote:
    > > >
    > > > mm/highmem.c/copy_from_high_bh() blocks interrupts while copying "down"
    > > > to a bounce buffer, for writing.
    > > > This function is only ever called from create_bounce() (which cannot
    > > > be called from an interrupt context - it may block), and the kmap
    > > > 'KM_BOUNCE_WRITE' is only used in copy_from_high_bh().
    > >
    > > If so it's not just the interrupt disable that is unnecessary, the
    > > "kmap_atomic()" should also be just a plain "kmap()", I think.
    > That might eat through kmap()'s virtual window too quickly.

    certainly not more quickly than a flood of allocation of highmem pages
    in anon mem. I don't see your point. kmap has to work just fine over
    there and the __cli/__sti was obviously useless. (should be faster
    because we won't need to invlpg at every bounce, but OTOH we'll flush
    the whole tlb after the wrap around but as said above if flushing the
    tlb too frequently is the issue we should simply improve kmap because
    the flood of kmap will happen anyways in the very fast paths regardless
    of the bounces)

    > I did think about adding a test to see if the page was already mapped,
    > and falling back to kmap_atomic() if it isn't. That should give the best
    > of both worlds?
    > Mark

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2005-03-22 12:56    [W:0.023 / U:0.248 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site