lkml.org 
[lkml]   [2001]   [Jul]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: WOL with 3c59x and 2.4.6-pre6 breaks WOL
    Andrew Morton wrote:
    > --- linux-2.4.6-pre8/drivers/pci/pci.c Sun Jul 1 16:11:25 2001
    > +++ linux-akpm/drivers/pci/pci.c Tue Jul 3 01:28:35 2001
    > @@ -425,7 +425,7 @@ int pci_enable_wake(struct pci_dev *dev,
    >
    > if (enable) value |= PCI_PM_CTRL_PME_STATUS;
    > else value &= ~PCI_PM_CTRL_PME_STATUS;
    > -
    > + value |= PCI_PM_CTRL_PME_ENABLE;
    > pci_write_config_word(dev, pm + PCI_PM_CTRL, value);
    >
    > return 0;

    wrong but it seems you spotted a bug in the code -- set/clear _ENABLE
    right above your change here. maybe read and write _STATUS
    unconditionally, for paranoia.

    --
    Jeff Garzik | The LSB is a bunch of crap.
    Building 1024 | E-mail for details.
    MandrakeSoft |
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 12:55    [W:0.031 / U:32.076 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site