lkml.org 
[lkml]   [2001]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [NFS] [PATCH] Bug in NFS - should init be allowed to set umask???


On Sat, 14 Jul 2001, Neil Brown wrote:

> On Friday July 13, torvalds@transmeta.com wrote:
> >
> > On Sat, 14 Jul 2001, Neil Brown wrote:
> > >
> > > I've found a 4th option. We make it so that fs->umask does not affect
> > > nfsd
> >
> > Me likee.
> >
> > Applied. I'd only like to double-check that you made sure you changed all
> > callers?
>
> There is just the call to vfs_mknod in net/unix/af_unix.c that I
> mentioned. I'm not sure what to do about that one.
>
> A
> find -name '*.[ch]' | xargs egrep 'vfs_(mkdir|mknod|create)'

RTFM grep(1). \< is your friend...

> 2 matches in net/unix/af_unix.c one is a comment, the other is the
> one in question
>
> To be maximally conservative, you might want to apply this patch,
> just in case it is important.

It is. Ability to connect == write permissions on AF_UNIX socket. So
umask matters.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:57    [W:0.057 / U:0.344 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site