Messages in this thread | | | Date | Fri, 13 Jul 2001 23:09:54 -0300 (BRT) | From | Marcelo Tosatti <> | Subject | Re: [PATCH] VM statistics code |
| |
On Sat, 14 Jul 2001, Andrew Morton wrote:
> Marcelo Tosatti wrote: > > > > Hi Linus, > > > > The following patch adds detailed VM statistics (reported via /proc/stats) > > which is tunable on/off by the CONFIG_VM_STATS option. > > We need this, bad. Two suggested changes: > > > > > +#define VM_STAT_INC_PTEUNMAP(zone) zone->stat.vm_pteunmap++; > > All these macros are a waste of space :) > > Much better to have: > > #define VM_STAT_ZONE(zone, op) zone->stat.op > > Then, at the call site: > > VM_STAT_ZONE(some_zone, vm_pteunmap++); > > Or, if you prefer, > > #define VM_STAT_ZONE_INC(zone, field) zone->field++ > > That way, you don't have to add a new macro each time > you add a new field.
You're right. Will do that.
> Also, a sysrq key which dumps the stats out, please - when > your box has wedged there ain't no way you'll be running > vmstat.
Agreed.
Thanks for your comments.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |