Messages in this thread | | | Date | Tue, 5 Jun 2001 23:28:07 -0700 (PDT) | From | Ion Badulescu <> | Subject | Re: [PATCH] Proper perfect filter setup for xircom_tulip_cb.c |
| |
On Wed, 6 Jun 2001, Keith Owens wrote:
> Nicely spotted. The X3201-3 Software Specification says nothing about > the segment bits for the filter, instead the information is tucked away > in the 21143 PCI/CardBus 10/100Mb/s Ethernet LAN Controller Hardware > Reference Manual. So Xircom have a software specification manual that > does not include the full software spec, oh the horrors.
If that were the only thing missing... At least I was able to catch it by simply being tidy -- I was going over the control bits to see which of them need to be/make sense to be set.
But what about setting the hash (the imperfect filter)? The 21143 docs say the *upper* 9 bits of the crc32 should be used; the Xircom docs are completely silent, and the driver currently uses the *lower* 9 bits of the crc32.
Oh, and for that matter, the hash is currently broken on the Xircom: unlike the 21143, the Xircom has 4 perfect filter slots in hash mode, not one, but the driver ignores this fact. The hash layout is also severely brain-damaged... I'll look into fixing it tomorrow -- by simply copying the fix from the patch I wrote for the other xircom driver (xircom_cb). :-)
Thanks, Ion
-- It is better to keep your mouth shut and be thought a fool, than to open it and remove all doubt.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |