Messages in this thread | | | From | Keith Owens <> | Subject | Re: [PATCH] 2.4.6-pre6 fix drivers/net/Config.in error | Date | Thu, 28 Jun 2001 20:43:38 +1000 |
| |
On Thu, 28 Jun 2001 10:45:55 +0200 (MET DST), Andrzej Krzysztofowicz <ankry@pg.gda.pl> wrote: >Keith Owens wrote: >> Index: 6-pre6.1/drivers/net/Config.in >> - dep_bool ' EISA, VLB, PCI and on board controllers' CONFIG_NET_PCI >> + if [ "$CONFIG_ISA" = "y" -o "$CONFIG_EISA" = "y" -o "$CONFIG_PCI" = "y" ]; then
>CONFIG_EISA check in this condition is redundant.
True, but the line is a cut and paste from higher up in drivers/net/Config.in. Even though it is redundant, it is consistent with the rest of the file.
drivers/net/Config.in needs a major cleanup, lots of the if statements can go and be replaced by dep_xxx statements, CONFIG_ETHERTAP is marked obsolete but is tested against experimental, CONFIG_ZNET is marked experimental but is tested against obsolete, etc. I started to clean up the file then decided to leave it, the entire thing is being replaced in 2.5 anyway.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |