Messages in this thread | | | From | "Michael Johnson" <> | Subject | Re: Changes to ide-cd for 2.4.1 are broken? | Date | Sun, 10 Jun 2001 17:41:34 -0700 |
| |
So, the patch you are proposing will always consider the tray open, even if it is closed. Why do you need this behavior?
Why is checking CDS_TRAY_OPEN, to see if the tray is open, broken?
The code in cdrom.c looks fine to me.
Michael
----- Original Message ----- From: "John Fremlin" <vii@users.sourceforge.net> To: "Michael Johnson" <johnsom@home.com> Cc: "Jens Axboe" <axboe@suse.de>; <Andries.Brouwer@cwi.nl>; "Alan Cox" <alan@lxorguk.ukuu.org.uk>; <linux-kernel@vger.kernel.org> Sent: Sunday, June 10, 2001 10:37 AM Subject: Re: Changes to ide-cd for 2.4.1 are broken?
> > Hi all, this is an old thread. It was started because the return value > from cd info was changed in 2.4.1 in the case when the tray might be > open or there simply be no disc in the drive for an IDE > CD-ROM. > > John Fremlin <chief@bandits.org> writes: > > > "Michael Johnson" <johnsom@home.com> writes: > > [...] > > > > >Right, old ATAPI has 3a/02 as the only possible condition, so we > > > >can't really tell between no disc and tray open. I guess the safest > > > >is to just keep the old behaviour for !ascq and report open. > > > > > I don't understand why the current(2.4.1) behavior is a problem... > > Unfortunately changing the return code means that the generic cdrom.c > code is broekn, in particular wrt to having the cdrom drive open > automatically when umounted, and to close when attempted to be > mounted. > > (You can set this mode with "cdd auto" if you have my asm-toys installed > http://ape.n3.net/programs/linux/asm-toys > ) > > The following patch fixes that. I also attempted to fix up similar > problems (where checking CDS_TRAY_OPEN is used to see if the tray is > open, which is obviously broekn). > >
---------------------------------------------------------------------------- ----
> > -- > > http://ape.n3.net >
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |