lkml.org 
[lkml]   [2001]   [May]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: page_launder() bug
    Date
    From
    "David S. Miller" <davem@redhat.com> said:
    > Jonathan Morton writes:
    > > >- page_count(page) == (1 + !!page->buffers));
    > >
    > > Two inversions in a row?
    >
    > It is the most straightforward way to make a '1' or '0'
    > integer from the NULL state of a pointer.

    IMVHO, it is clearer to write:

    page_count(page) == 1 + (page->buffers != NULL)

    At least, the original poster wouldn't have wondered, and I wouldn't have
    had to think a bit to find out what it meant... If gcc generates worse code
    for this, it should be fixed.
    --
    Dr. Horst H. von Brand mailto:vonbrand@inf.utfsm.cl
    Departamento de Informatica Fono: +56 32 654431
    Universidad Tecnica Federico Santa Maria +56 32 654239
    Casilla 110-V, Valparaiso, Chile Fax: +56 32 797513
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 12:52    [W:0.033 / U:1.808 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site