Messages in this thread | | | Subject | Re: page_launder() bug | Date | Mon, 07 May 2001 21:00:55 -0400 | From | Horst von Brand <> |
| |
"David S. Miller" <davem@redhat.com> said: > Linus Torvalds writes: > > The whole "dead_swap_page" optimization in the -ac tree is apparentrly > > completely bogus. It caches a value that is not valid: you cannot > > reliably look at whether the page has buffers etc without holding the > > page locked.
[...]
> Please show me how this is illegal. Everyone comes to this conclusion > when the first read the code, that I am doing something illegal, then > when I explain what that dead_swap_page thing is doing and they read > it a second time (how shocking! :-) they go "oh, I see".
Then it might be a better use of your time to place a comment in there telling the gentle reader what is going on, and not tell them each time they come asking/screaming that it is wrong. If even Linus gets confused by it, it is mandatory IMVVHO -- Horst von Brand vonbrand@sleipnir.valparaiso.cl Casilla 9G, Vin~a del Mar, Chile +56 32 672616 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |