Messages in this thread | | | From | "Khachaturov, Vassilii" <> | Subject | RE: [PATCH] 2.4.x: update for PCI vendor id 0x12d4 | Date | Thu, 31 May 2001 11:31:52 -0400 |
| |
> From: Jeff Garzik [mailto:jgarzik@mandrakesoft.com] > > > "Khachaturov, Vassilii" <Vassilii.Khachaturov@comverse.com> wrote: > > >What I don't understand is why pci_ids.h doesn't get > > >generated from pci.ids as well. > > Although they are similar, you cannot reliably generate useable C > constants from english words in the PCI id list...
I agree. Still, right now the update of the 2 is independant. Do you think that merging the C constant names (with the common prefix stripped) into the PCI id list so that there's a single source to control it would be better?
It's also possible to apply an heuristic to only store "exception" C names there - just take the 1st word and make it uppercase:
pci.ids: 1043 Asustek Computer, Inc.
would automatically map into what it is now: pci_ids.h #define PCI_VENDOR_ID_ASUSTEK 0x1043
whereas for 0x1042 one would have to change in the pci.ids: 1042 Micron 1000 FDC 37C665 1001 37C922 3000 Samurai_0 3010 Samurai_1 3020 Samurai_IDE
into 1042{PCTECH} Micron 1000{RZ1000} FDC 37C665 1001{RZ1001} 37C922 3000 Samurai_0 3010 Samurai_1 3020 Samurai_IDE
to generate in the .h #define PCI_VENDOR_ID_PCTECH 0x1042 #define PCI_DEVICE_ID_PCTECH_RZ1000 0x1000 #define PCI_DEVICE_ID_PCTECH_RZ1001 0x1001 #define PCI_DEVICE_ID_PCTECH_SAMURAI_0 0x3000 #define PCI_DEVICE_ID_PCTECH_SAMURAI_1 0x3010 #define PCI_DEVICE_ID_PCTECH_SAMURAI_IDE 0x3020
You get the idea... This way it is also very easy to look up the .ids file and see instantly where the names mismatch severely.
Does this make sense? If you think it does (say so), I can easily make this into the tree of your choice in a backward-compatible way. There'll be an option to generate the older .ids, too, for easier merge back into the 2.2 series.
Vassilii P.S. Even if you don't think the merge of the 2 files is worth it, don't forget to apply the 12d4 patch... - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |