lkml.org 
[lkml]   [2001]   [May]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [ PATCH ]: disable pcspeaker kernel: 2.4.2 - 2.4.5
    > > less code / one int more in the kernel
    > > or
    > > more code and #ifs / one int less in the kernel
    >
    > if the #ifdefs bloat the code 4 times the size of the simple patch, then
    > we obviously want 4 bytes more in the kernel.

    Okay.

    > > And what about the code from kernel/sys.c ? The version you provided
    > > doesn't take care of what's the default value of pcspeaker. This would
    > > make it undefined, which is not really good.
    >
    > the default value is 0, that is good enough.

    hmm.. I don't think so... value of 1 would be much better, because
    0 normally disables the speaker.
    So setting somewhere pcspeaker_enabled = 1 should be better
    than having it with 0.

    So in kernel/sysctl.c:

    int pcspeaker_enabled = 1;

    or anybody against this ?

    Nico


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:17    [W:0.049 / U:179.376 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site