[lkml]   [2001]   [May]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: Why side-effects on open(2) are evil. (was Re: [RFD w/info-PATCH]device arguments from lookup)
    On Saturday 26 May 2001 05:07, Edgar Toernig wrote:
    > Daniel Phillips wrote:
    > > Oops, oh wait, there's already another open point: your breakage
    > > examples both rely on opening ".". You're right, "." should always
    > > be a directory and I believe that's enforced by the VFS. So we
    > > don't have an example of breakage yet.
    > That's just because I did a simple "ls". But it doesn't make a
    > difference. The magicdevs _are_ directories and
    > chdir("magicdev");
    > open(".", O_RDONLY);
    > shouldn't open the device.

    It won't, the open for "." is handled in the VFS, not the filesystem -
    it will open the directory. (Without needing to be told it's a
    directory via O_DIRECTORY.) If you do open("magicdev") you'll get the
    device, because that's handled by magicdevfs.

    I'm not claiming there isn't breakage somewhere, just that we didn't
    find it on this attempt.


    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2005-03-22 12:54    [W:0.020 / U:1.380 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site