lkml.org 
[lkml]   [2001]   [May]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: PS/2 Esdi patch #8
    Hal Duston wrote:

    > http://www.sound.net/~hald/projects/ps2esdi/ps2esdi-2.4.4-patch4
    >
    > Hal Duston
    > hald@sound.net

    You PS/2 ESDI guys might want to set the max sectors for your
    driver - old default used to be 128, currently 255 (which maybe
    hardware can handle ok?) - the xd and hd drivers were broken until
    a similar fix was added to them.

    Probably makes sense for driver to set it regardless, seeing
    as default (MAX_SECTORS) has changed several times over last
    few months. At least then it will be under driver control
    and not at the mercy of some global value.

    Paul.

    --- drivers/block/ps2esdi.c~ Sun Apr 29 04:42:35 2001
    +++ drivers/block/ps2esdi.c Thu May 24 16:33:46 2001
    @@ -117,6 +117,7 @@
    static char ps2esdi_valid[MAX_HD];
    static int ps2esdi_sizes[MAX_HD << 6];
    static int ps2esdi_blocksizes[MAX_HD << 6];
    +static int ps2esdi_maxsect[MAX_HD << 6];
    static int ps2esdi_drives;
    static struct hd_struct ps2esdi[MAX_HD << 6];
    static u_short io_base;
    @@ -414,8 +415,11 @@

    ps2esdi_gendisk.nr_real = ps2esdi_drives;

    - for (i = 0; i < (MAX_HD << 6); i++)
    + /* 128 was old default, maybe maxsect=255 is ok too? - Paul G. */
    + for (i = 0; i < (MAX_HD << 6); i++) {
    + ps2esdi_maxsect[i] = 128;
    ps2esdi_blocksizes[i] = 1024;
    + }

    request_dma(dma_arb_level, "ed");
    request_region(io_base, 4, "ed");


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:17    [W:0.023 / U:120.056 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site