Messages in this thread | | | Date | Mon, 21 May 2001 19:05:45 +0200 | From | Francois Romieu <> | Subject | Re: PATCH: maestro ported to 2.4 PCI API |
| |
Marcus Meissner <Marcus.Meissner@caldera.de> ecrit : [...] > if( request_region(iobase, 256, card_names[card_type]) == NULL ) > { > printk(KERN_WARNING "maestro: can't allocate 256 bytes I/O at 0x%4.4x\n", iobase); > - return 0; > - } > - > - /* this was tripping up some machines */ > - if(pcidev->irq == 0) { > - printk(KERN_WARNING "maestro: pci subsystem reports irq 0, this might not be correct.\n"); > + return -EBUSY; > } > > /* just to be sure */ > @@ -3406,7 +3429,7 @@ > if(card == NULL) > { > printk(KERN_WARNING "maestro: out of memory\n"); > - return 0; > + return -ENOMEM;
request_region is unbalanced in this return path.
-- Ueimor - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |