lkml.org 
[lkml]   [2001]   [May]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: iso9660 endianness cleanup patch
    Linus Torvalds wrote:
    >
    > On Mon, 30 Apr 2001, H. Peter Anvin wrote:
    > >
    > > The attached patch fixes both. It is against 2.4.4, but from the looks
    > > of it it should patch against -ac as well.
    >
    > Btw, please use "static inline" instead of "extern inline", as gcc may
    > decide not to inline the latter at all, leading to confusing link-time
    > errors. (Gcc may also decide not to inline "static inline", but then gcc
    > will output the actual body of the function out-of-line if it gets used,
    > so you don't get the link-time failure).
    >
    > Right now only certain broken versions of gcc will actually show this
    > behaviour, I think, but it's at least in theory going to be an issue.
    >

    I guess I personally prefer an error over completely broken behaviour,
    but feel free to change it.

    -hpa

    --
    <hpa@transmeta.com> at work, <hpa@zytor.com> in private!
    "Unix gives you enough rope to shoot yourself in the foot."
    http://www.zytor.com/~hpa/puzzle.txt
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:17    [W:0.086 / U:0.560 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site