Messages in this thread | | | Date | Thu, 5 Apr 2001 16:52:11 +0000 | From | "Heinz J. Mauelshagen" <> | Subject | Re: /dev/loop0 over lvm... leading to d-state :-( |
| |
On Thu, Apr 05, 2001 at 05:37:31PM +0200, Jens Axboe wrote: > On Thu, Apr 05 2001, Heinz J. Mauelshagen wrote: > > > Irks, another one. lvm_make_request_fn also needs to call b_end_io > > > if a map fails. > > > > This is wrong. > > > > In case of an io error we do already call buffer_IO_error() on 2.4 in > > lvm_map(). > > Where? Calling buffer_IO_error would be ok, but there are no such calls > in 2.4.3. I just stated elsewhere that submit_bh should probably be > clearing the dirty bit, not ll_rw_block, in which case the b_end_io > is fine. But buffer_IO_error is probably more clear. I trust you'll > take care of that part then.
Sorry, didn't mention that you need to patch the driver with the recent LVM software in order to get it.
I've send the patch a while ago to Linus to get it into 2.4.3 but he obviously didn't include it (likely because he thought it was too large ;-)
He didn't comment back to me at all though :-( Maybe this will help.
Linus?
> > -- > Jens Axboe >
--
Regards, Heinz -- The LVM Guy --
*** Software bugs are stupid. Nevertheless it needs not so stupid people to solve them ***
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
Heinz Mauelshagen Sistina Software Inc. Senior Consultant/Developer Am Sonnenhang 11 56242 Marienrachdorf Germany Mauelshagen@Sistina.com +49 2626 141200 FAX 924446 =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |