Messages in this thread | | | From | Andreas Dilger <> | Subject | Re: hundreds of mount --bind mountpoints? | Date | Tue, 24 Apr 2001 12:47:38 -0600 (MDT) |
| |
Eric Mouw writes: > Al is right, it is no rocket science. Here is a patch against > 2.4.4-pre6 for procfs and isofs. It took me an hour to do because I'm > not familiar with the fs code. It compiles, and the procfs code even > runs (sorry, no CDROM player availeble on my embedded StrongARM > system), though it is possible that there are some bugs in it.
While I applaud your initiative, you made an unfortunate choice of filesystems to convert. The iso_inode_info is only 4*__u32, as is proc_inode_info. Given that we still need to keep a pointer to the external info structs, and the overhead of the slab cache itself (both CPU usage and memory overhead, however small), I don't think it is worthwhile to have isofs and procfs in separate slabs.
On the other hand, sockets and shmem are both relatively large... Watch out that the *_inode_info structs have all of the fields initialized, because the union field is zeroed for us, but slab is not.
Cheers, Andreas -- Andreas Dilger \ "If a man ate a pound of pasta and a pound of antipasto, \ would they cancel out, leaving him still hungry?" http://www-mddsp.enel.ucalgary.ca/People/adilger/ -- Dogbert - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |