Messages in this thread | | | Date | Sat, 21 Apr 2001 00:02:56 -0700 | From | Jeremy Fitzhardinge <> | Subject | Re: Fix for SMP deadlock in autofs4 |
| |
On Fri, Apr 20, 2001 at 10:59:43PM -0700, Linus Torvalds wrote: > It's untested, but looks fairly obvious. It removes the increment, and > changes autofs4_expire() to properly bump the count of the returned dentry > (and callers will dput() it when done). This may be unnecessarily careful, > but it's the RightThing(tm) to do.
I suppose so. It is pretty paranoid, because of autofs4's extra reference it can't (shouldn't) ever drop to zero until the filesystem allows it to drop to zero. In other words, if it helps, it's hiding another bug. But you're right, if this were a general routine, it should definitely return with an elevated count.
> Jeremy, would you mind verifying that this WorksForYou(tm)?
Looks fine to me. I'll give it a spin.
J [unhandled content-type:application/pgp-signature] | |