lkml.org 
[lkml]   [2001]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: CML1 cleanup patch
Peter Samuelson <peter@cadcamlab.org>:
>
> [Jeff Garzik]
> > > It stays "8139too". Donald Becker's rtl8139.c continues to exist
> > > outside the kernel.
>
> Honestly, Jeff, I don't see how it matters -- because if you are
> downloading an external driver, you are not going through the config
> system anyway.
>
> But ... "maintanicus selector est" (my pseudo-Latin for "the maintainer
> gets to choose") so I support your stand.

And that's an argument I can buy, too. I'll restore the TOO prefix
in my change list.

> Eric, the issue arose because you are obliquely proposing -- nay,
> insisting on -- a policy change. CONFIG_8139TOO is a perfectly valid
> preprocessor token and a perfectly valid GNU Make macro name. It
> corresponds with a source file '8139too.c' which is also perfectly
> valid.
>
> Did it never occur to you that by insisting on a policy change (and
> related code changes), with no discussion, consensus or mandate, and
> which fixes no current bugs ... that a few toes may feel stepped on?

Actually, that's not what I did. One of the principal PPC maintainers
agreed to get the PPC numeric-prefix symbols (9 of the 20) cleaned up,
but dropped the ball. I waited on this as long as I thought I could.

> The burden of proof is yours. Why should a CML2 design decision
> (stripping of CONFIG_ in the configuration files) change what seems to
> be an entirely reasonable policy? Especially since there are multiple
> ways, which you have rejected, to work around the lexical problem in
> CML2 itself?

The workarounds would be slow, or ugly, or both. As I said -- I might
have gone with them, but there since had to be a fix patch anyway, and
I had buy-in for all but 11 of the 39 changes...
--
<a href="http://www.tuxedo.org/~esr/">Eric S. Raymond</a>

According to the National Crime Survey administered by the Bureau of
the Census and the National Institute of Justice, it was found that
only 12 percent of those who use a gun to resist assault are injured,
as are 17 percent of those who use a gun to resist robbery. These
percentages are 27 and 25 percent, respectively, if they passively
comply with the felon's demands. Three times as many were injured if
they used other means of resistance.
-- G. Kleck, "Policy Lessons from Recent Gun Control Research,"
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:17    [W:0.800 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site