Messages in this thread Patch in this message | | | Date | Fri, 2 Mar 2001 04:53:03 -0600 | From | Philipp Rumpf <> | Subject | Re: 2.4.2ac8 lost char devices |
| |
On Fri, Mar 02, 2001 at 03:05:32PM +0900, tachino Nobuhiro wrote: > > Hello, > > At Fri, 02 Mar 2001 00:42:28 -0500, > <rml@ufl.edu> wrote: > > > > actually, its not just ps/2 mice -- it seems to be something generic to char > > devices. agpgartis failing to register itself, too. > > > > what changed with char device handling from ac7 to ac8? > > > > robert love > > rml@ufl.edu > > - > > misc_register() in drivers/char/misc.c seems to have a problem.
I guess it's too late now to pretend it's not my fault. I foolishly assumed if it would boot for me I couldn't have broken it too badly.
> + c = misc_list.next; > + > + while ((c != &misc_list) && (c->minor != misc->minor)) > + c = c->next; > + if (c == &misc_list) { > > This should be (c != &misc_list)
Correct. Alan,
diff -ur linux/drivers/char/misc.c linux-prumpf/drivers/char/misc.c --- linux/drivers/char/misc.c Fri Mar 2 02:48:04 2001 +++ linux-prumpf/drivers/char/misc.c Fri Mar 2 02:49:43 2001 @@ -180,7 +180,7 @@ while ((c != &misc_list) && (c->minor != misc->minor)) c = c->next; - if (c == &misc_list) { + if (c != &misc_list) { up(&misc_sem); return -EBUSY; } - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |