Messages in this thread | | | From | Andreas Dilger <> | Subject | Re: [CHECKER] 120 potential dereference to invalid pointers errors forlinux 2.4.1 | Date | Mon, 19 Mar 2001 09:24:48 -0700 (MST) |
| |
Jeff Garzic writes: > > [BUG] init_etherdev could return NULL > > /u2/acc/oses/linux/2.4.1/drivers/net/3c515.c:604:corkscrew_found_device: ERROR:NULL:603:604: Using unknown ptr "dev" illegally! set by 'init_etherdev':603 > > > > Start ---> > > dev = init_etherdev(dev, sizeof(struct corkscrew_private)); > > Error ---> > > dev->base_addr = ioaddr; > > dev->irq = irq; > > init_etherdev is a special case -- It can conditionally take NULL as its > first argument. If that is the case, when an allocation is performed, > and the return val needed to be checked for NULL. If init_etherdev's > first arg is guaranteed to be non-NULL, you do not need to check its > return value. 3c515 is one such case.
If this is the case, why not change it to look like:
init_etherdev(dev, sizeof(struct corkscrew_private));
so it doesn't appear that you are setting "dev" again?
> > dev = init_trdev(dev,0);
Ditto, don't make it look like "dev" is getting set on the return value, when it is already set when calling the function.
> > /u2/acc/oses/linux/2.4.1/drivers/pcmcia/bulkmem.c:231:setup_erase_request: ERROR:NULL:230:231: Using unknown ptr "busy" illegally! set by 'kmalloc':230 > > > > Start ---> > > busy = kmalloc(sizeof(erase_busy_t), GFP_KERNEL); > > Error ---> > > This sizeof() construct may be a special case for your checker, but it's > a common one for the kernel... It definitely doesn't de-reference a > pointer.
It is the "busy" pointer that appears to be dereferenced, not the sizeof. We need something like (ERASE_BAD_KMALLOC doesn't yet exist):
else if ((busy = kmalloc(sizeof(erase_busy_t), GFP_KERNEL)) == NULL) erase->State = ERASE_BAD_KMALLOC; else { erase->State = 1; ... }
Cheers, Andreas -- Andreas Dilger \ "If a man ate a pound of pasta and a pound of antipasto, \ would they cancel out, leaving him still hungry?" http://www-mddsp.enel.ucalgary.ca/People/adilger/ -- Dogbert - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |