lkml.org 
[lkml]   [2001]   [Mar]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] off-by-1 error in ide-probe (2.4.x)
    On Sun, 18 Mar 2001, Linus Torvalds wrote:

    >
    >
    > On Sun, 18 Mar 2001, Jens Axboe wrote:
    > >
    > > The 256 is _not_ a bug in the driver, it's more likely a bug in your
    > > drive. 256 is a perfectly legal transfer size. That said, maybe it is
    > > a good idea to leave it at 255 just for safety on drives not handling
    > > 0 sectors == 128kB transfer.
    >
    > Agreed. That would be a trivially easy bug in the firmware, limiting to
    > 255 sectors seems safer.

    Guys which side of the counter is the decrementer?

    Telling the drive to transfer 256 sectors in PIO is filling the
    sector_count register with '0' == 'zero'.

    As long as 255 == 255 and 0 == 256 for total sectors to transfer all is
    cool.


    Andre Hedrick
    Linux ATA Development

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:29    [W:0.022 / U:92.740 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site