lkml.org 
[lkml]   [2001]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [CFT][PATCH] Re: fat problem in 2.4.2
    Hi,

    On Thu, 1 Mar 2001, Alexander Viro wrote:

    > +static int generic_vm_expand(struct address_space *mapping, loff_t size)
    > +{
    > + struct page *page;
    > + unsigned long index, offset;
    > + int err;
    > +
    > + if (!mapping->a_ops->prepare_write || !mapping->a_ops->commit_write)
    > + return -ENOSYS;
    > +
    > + offset = (size & (PAGE_CACHE_SIZE-1)); /* Within page */
    > + index = size >> PAGE_CACHE_SHIFT;

    For affs I did basically the same with a small difference:

    offset = ((size-1) & (PAGE_CACHE_SIZE-1)) + 1;
    index = (size-1) >> PAGE_CACHE_SHIFT;

    That works fine here and allocates a page in the cache more likely to be
    used.

    bye, Roman

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:29    [W:0.019 / U:59.392 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site