Messages in this thread | | | Date | Wed, 28 Feb 2001 09:18:59 -0800 | From | Robert Read <> | Subject | Re: [patch] set kiobuf io_count once, instead of increment |
| |
On Tue, Feb 27, 2001 at 10:50:54PM -0300, Marcelo Tosatti wrote: > > > It seems your patch breaks bh allocation failure handling. If > get_unused_buffer_head() fails, iobuf->io_count never reaches 0, so > processes waiting on kiobuf_wait_for_io() will block forever. >
This is true, but it looks like the brw_kiovec allocation failure handling is broken already; it's calling __put_unused_buffer_head on bhs without waiting for them to complete first. Also, the err won't be returned if the previous batch of bhs finished ok. It looks like brw_kiovec needs some work, but I'm going to need some coffee first...
robert - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |