Messages in this thread | | | Date | Fri, 23 Feb 2001 09:15:29 -0500 | From | Jeff Garzik <> | Subject | Re: [PATCH] drivers/char/serial.c unchecked ioremap() calls |
| |
Arnaldo Carvalho de Melo wrote: > > Em Fri, Feb 23, 2001 at 10:53:59AM +0300, Andrey Panin escreveu: > > > > Hi all, > > > > 16x50 serial driver doesn't check ioremap() return value. > > Atached patch should fix this it. > > humm, have not checked, but it seems as if you don't release the previous > successful mappings on failure. Wipe out this message if I was too quick to > answer and this is not true. 8)
Also, the proper return from a failed ioremap is -ENOMEM, so I think Andrey's serial.c patch should modify some functions to return a failure code...
Jeff
-- Jeff Garzik | "You see, in this world there's two kinds of Building 1024 | people, my friend: Those with loaded guns MandrakeSoft | and those who dig. You dig." --Blondie - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |