Messages in this thread Patch in this message |  | | | Subject | Re: Changes to ide-cd for 2.4.1 are broken? | | From | John Fremlin <> | | Date | 22 Feb 2001 16:46:59 +0000 |
| |
Jens Axboe <axboe@suse.de> writes:
[...]
> > You know all about this stuff, so probably I am mistaken. > > However, my copy of SFF8020-r2.6 everywhere has > > "Sense 02 ASC 3A: Medium not present" without giving > > subcodes to distinguish Tray Open from No Disc. > > So, it seems to me that drives built to this spec will not have > > nonzero ASCQ. > > Right, old ATAPI has 3a/02 as the only possible condition, so we > can't really tell between no disc and tray open. I guess the safest > is to just keep the old behaviour for !ascq and report open.
Jens, you are maintainer? Could you ask Linus or Alan to revert the change below?
diff -u --recursive --new-file v2.4.0/linux/drivers/ide/ide-cd.c linux/drivers/ide/ide-cd.c --- v2.4.0/linux/drivers/ide/ide-cd.c Tue Jan 2 16:59:17 2001 +++ linux/drivers/ide/ide-cd.c Sun Jan 28 13:37:50 2001 @@ -2324,11 +2309,17 @@ sense.ascq == 0x04) return CDS_DISC_OK;
+ + /* + * If not using Mt Fuji extended media tray reports, + * just return TRAY_OPEN since ATAPI doesn't provide + * any other way to detect this... + */ if (sense.sense_key == NOT_READY) { - /* ATAPI doesn't have anything that can help - us decide whether the drive is really - emtpy or the tray is just open. irk. */ - return CDS_TRAY_OPEN; + if (sense.asc == 0x3a && (!sense.ascq||sense.ascq == 1))+ return CDS_NO_DISC; + else + return CDS_TRAY_OPEN; }
-- http://www.penguinpowered.com/~vii - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |