Messages in this thread | | | From | "Peter T. Breuer" <> | Subject | Re: plugging in 2.4. Does it work? | Date | Wed, 21 Feb 2001 00:32:08 +0100 (MET) |
| |
"A month of sundays ago Jens Axboe wrote:" > Forgot to mention that the above doesn't make much sense at all. If > there are no errors, you loop through ending all the buffers. Then
Yes, that's right, thanks. I know I do one more end_that_request_first than is necessary, but it is harmless as there is a guard in the kernel code. At least, it's harmless until someone removes that guard.
It is like that because I added the while loop to the front of the code I already had working when I decided to try plugging.
> you fall through and end the the first (non-existant) chunk? And > end_that_request_first does not need to hold the io_request_lock, > you can move that down to protect end_that_request_last.
OK, thanks!
Peter - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |