Messages in this thread | | | Date | Mon, 19 Feb 2001 23:45:19 -0500 | From | Tom Leete <> | Subject | Re: [IDE] meaningless #ifndef? |
| |
Bill Wendling wrote: > > Also sprach Andre Hedrick: > } On Mon, 19 Feb 2001, Pozsar Balazs wrote: > } > } > from drivers/ide/ide-features.c: > } > > } > /* > } > * All hosts that use the 80c ribbon mus use! > } > */ > } > byte eighty_ninty_three (ide_drive_t *drive) > } > { > } > return ((byte) ((HWIF(drive)->udma_four) && > } > #ifndef CONFIG_IDEDMA_IVB > } > (drive->id->hw_config & 0x4000) && > } > #endif /* CONFIG_IDEDMA_IVB */ > } > (drive->id->hw_config & 0x6000)) ? 1 : 0); > } > } > } > > } > If i see well, then this is always same whether CONFIG_IDEDMA_IVB is > } > defined or not. > } > What's the clue? > } > [snip...] > > The use of the ternary operator is superfluous, though...and makes the > code look ugly IMNSHO :). >
Check return type. 0 == ((byte) 0x6000).
Tom - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |