lkml.org 
[lkml]   [2001]   [Feb]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] minor ne2k-pci irq fix
On Thu, 1 Feb 2001, Martin Diehl wrote:
> On Wed, 31 Jan 2001 davej@suse.de wrote:
> > I think it would be better to move the pci_enable_device(pdev);
> > above all this, as we should enable the device before reading the
> > pdev->resource[] too iirc.

Agreed.


> Probably I've missed this because the last time I hit such a thing was
> when my ob800 bios mapped the cardbus memory BAR's into bogus legacy
> 0xe0000 area. Hence there was good reason to read and correct this before
> trying to enable the device.

This is a PCI fixup, the driver shouldn't have to worry about this..


> BTW, will it ever happen the kernel starts remapping BAR's when enabling
> devices?

huh? The two steps do not occur simultaneously. The enabling should
occur first, at which point the BARs should be useable. The remapping
occurs after that. If the BARs are not usable after remapping, that is
a PCI quirk that needs to be added to the list [probably].

Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:17    [from the cache]
©2003-2011 Jasper Spaans. Advertise on this site