[lkml]   [2001]   [Dec]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] i810_audio fix for version 0.11
    On Saturday 08 December 2001 11:36, Doug Ledford wrote:
    > Andris Pavenis wrote:
    > >On Saturday 08 December 2001 10:39, Andris Pavenis wrote:
    > >>Sorry, but this patch is still not OK. It still causes system
    > >>locking up for me.
    > >>
    > >>In some cases I have (I added printk in __start_dac):
    > >> dmabuf->count = 0
    > >> dmabuf->ready = 1
    > >> dmabuf->enable = 1
    > >> PCM_ENABLE_OUTPUT set in dmabuf->triger
    > Actually, since the problem is that there are obviously some "just in
    > case" type calls if i810_update_lvi(), the best answer is not to even go
    > through all those motions when dmabuf->count == 0. So, I would add a
    > line to i810_update_lvi() that makes it return without doing anything
    > when dmabuf->count == 0. That one line should solve your lockups (and
    > finalize the 0.12 version).

    Why returning non zero from __start_dac() and similar procedures when
    something real has been done there is so bad. Using such return code would
    ensure we never try to wait for results of __start_dac() if nothing is done
    by this procedure. I think such way is also more safe against possible future
    modifications as real conditions are only in a single place. Keeping them in
    2 places is possible source of bitrot if driver will be updated in future.

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2005-03-22 13:13    [W:2.412 / U:1.004 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site