lkml.org 
[lkml]   [2001]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] 2.4.17-pre7: fdomain_16x0_release undeclared
    Date
    From
    > > Another partly related problem is a warning in fdomain.c:
    > >
    > > fdomain.c: In function `fdomain_16x0_release':
    > > fdomain.c:2045: warning: control reaches end of non-void function
    > >
    > > I wonder if the patches that introduce warnings should be allowed in the
    > > stable branch? Anyway, comparing with other SCSI drivers I see that 0
    > > should be returned and scsi_unregister(shpnt) should be called before
    > > that.

    All the drivers I looked at return 1 and don't call scsi_unregister(shpnt).
    Inspecting the core code shows that

    1. The return code is ignored (see I did test it worked 8))
    2. scsi_unregister() is done by the core code for us

    So I believe it simply needs a

    return 1

    on the end
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:14    [W:0.024 / U:121.896 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site