Messages in this thread | | | Date | Fri, 30 Nov 2001 01:56:00 -0800 | From | Andrew Morton <> | Subject | Re: [patch] smarter atime updates |
| |
OGAWA Hirofumi wrote: > > #define UPDATE_ATIME(inode) \ > do { \ > if ((inode)->i_atime != CURRENT_TIME) \ > update_atime (inode); \ > } while (0) >
yes, that'd be fine. The more conventional approach would be to blow away the strange UPPER CASE name and:
static inline void update_atime(struct inode *inode) { if (inode->i_atime != CURRENT_TIME) __update_atime(inode); }
But that would be a bigger patch, and I rather like shaving off three quarters of the sys_read() overhead with a two-liner ;)
- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |