Warning: DOMDocument::loadXML() [function.DOMDocument-loadXML]: Input is not proper UTF-8, indicate encoding ! Bytes: 0xF0 0xCA 0x33 0x03 in Entity, line: 21 in /srv/lkml.org/scripts/getmail.php on line 216

Warning: DOMDocument::loadXML() [function.DOMDocument-loadXML]: PCDATA invalid Char value 3 in Entity, line: 21 in /srv/lkml.org/scripts/getmail.php on line 216

Warning: XSLTProcessor::transformToXml() expects parameter 1 to be object, boolean given in /srv/lkml.org/scripts/getmail.php on line 219
This message generated a parse failure. Raw output follows here. Please use 'back' to navigate. From devnull@lkml.org Fri Jan 9 07:09:52 2009 Received: from spaans.ds9a.nl (adsl-xs4all.ds9a.nl [213.84.159.51]) by kylie.puddingonline.com (8.11.6/8.11.6) with SMTP id g8IGC0X20455 for ; Wed, 18 Sep 2002 18:12:01 +0200 Received: (qmail 437 invoked from network); 18 Sep 2002 07:10:43 -0000 Received: from unknown (HELO spaans.ds9a.nl) (3ffe:8280:10:360:202:44ff:fe2a:a1dd) by mayo.ipv6.ds9a.nl with SMTP; 18 Sep 2002 07:10:43 -0000 Received: (qmail 10684 invoked by uid 1000); 17 Sep 2002 20:46:57 -0000 Received: (maildatabase); juh Received: (qmail 3773 invoked by alias); 1 Dec 2001 06:15:46 -0000 Received: ðÊ3il 3751 invoked from network); 1 Dec 2001 06:15:45 -0000 Received: from digger.ds9a.nl (HELO outpost.powerdns.com) (postfix@::ffff:213.244.168.211) by spaans.ds9a.nl with SMTP; 1 Dec 2001 06:15:45 -0000 Received: from vger.kernel.org (vger.kernel.org [66.187.233.194]) by outpost.powerdns.com (Postfix) with ESMTP id 15469C6BAC for ; Sat, 1 Dec 2001 02:17:48 +0100 (CET) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Fri, 30 Nov 2001 20:05:59 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Fri, 30 Nov 2001 20:05:50 -0500 Received: from gateway-1237.mvista.com ([12.44.186.158]:38388 "EHLO hermes.mvista.com") by vger.kernel.org with ESMTP id ; Fri, 30 Nov 2001 20:05:38 -0500 Received: from data.mvista.com (IDENT:root@data.mvista.com [10.230.3.2]) by hermes.mvista.com (8.11.0/8.11.0) with ESMTP id fB115wB27466; Fri, 30 Nov 2001 17:05:59 -0800 Received: from mvista.com (IDENT:george@localhost [127.0.0.1]) by data.mvista.com (8.9.3/8.9.3) with ESMTP id RAA29069; Fri, 30 Nov 2001 17:05:00 -0800 Message-Id: <3C082CBA.B66BF30F@mvista.com> Date: Fri, 30 Nov 2001 17:04:58 -0800 From: george anzinger Organization: Monta Vista Software X-Mailer: Mozilla 4.77 [en] (X11; U; Linux 2.2.12-20b i686) X-Accept-Language: en Mime-Version: 1.0 To: "David C. Hansen" Cc: Alexander Viro , linux-kernel@vger.kernel.org, Linus Torvalds Subject: Re: [LART] pc_keyb.c changes References: <3C07FB73.9030708@sr71.net> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org X-Spam-Tag: 1 Lines: 34 "David C. Hansen" wrote: > > Alexander Viro wrote: > > > Could the person who switched from BKL to spin_lock_irqsave() in > > pc_keyb.c please share whatever the hell he had been smoking? Free clue: > > disabling interrupts for long intervals to improve scalability is right up > > there with fighting for peace and fucking for virginity. > As I slowly raise my hand to take, um credit.... > > This is definitely one of the drivers I to take a second look at, now > that I know about the BKL being held for block and char device opens. > Do you have any ideas how else to do this safely since aux_count is > referenced during an interrupt? > Um, staying as far away from that bit of source as possible, I will offer: It depends on how it is referenced. If it is just a counter, you may be able to just make it atomic. If it needs to "stick" for a little longer, then consider if there are many readers and only a few writers, in which case look at the read/write_lockirq code, however, this does have the down side of irq off. BKL did not protect against interrupts, so one wonders if the irq bit is needed at all. -- George george@mvista.com High-res-timers: http://sourceforge.net/projects/high-res-timers/ Real time sched: http://sourceforge.net/projects/rtsched/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/