lkml.org 
[lkml]   [2001]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [CFT][PATCH] /proc/interrupts fixes
On Thu, Nov 22, 2001 at 06:36:44PM -0500, Alexander Viro wrote:
> Patch works on x86 and should work on every architecture where
> it manages to build. Hopefully - all of them. IOW, I've done the
> conversion for all architectures, but there could be typos. Patch
> is very straightforward - see yourself.

Is /proc/interrupts now allowed only on s390, x86 and mips? ;-)
Also, typeof(x == y) is int, so (void *)(*pos == 0) on 64-bit
platforms produces a compiler warning.
With appended patch this compiles and works fine on alpha.
Thanks for cleaning up the /proc mess!

Ivan.

--- 2.5.1p3/fs/proc/proc_misc.c Thu Nov 29 13:01:23 2001
+++ linux/fs/proc/proc_misc.c Thu Nov 29 15:06:51 2001
@@ -318,7 +318,7 @@ static int partitions_read_proc(char *pa

static void *single_start(struct seq_file *p, loff_t *pos)
{
- return (void *)(*pos == 0);
+ return NULL + (*pos == 0);
}
static void *single_next(struct seq_file *p, void *v, loff_t *pos)
{
@@ -561,9 +561,7 @@ void __init proc_misc_init(void)
entry->proc_fops = &proc_kmsg_operations;
create_seq_entry("mounts", 0, &proc_mounts_operations);
create_seq_entry("cpuinfo", 0, &proc_cpuinfo_operations);
-#if defined(CONFIG_ARCH_S390) || defined(CONFIG_X86) || defined(CONFIG_ARCH_MIPS)
create_seq_entry("interrupts", 0, &proc_interrupts_operations);
-#endif
#ifdef CONFIG_MODULES
create_seq_entry("ksyms", 0, &proc_ksyms_operations);
#endif
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:13    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site