lkml.org 
[lkml]   [2001]   [Nov]   [24]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateSat, 24 Nov 2001 01:58:16 -0500 (EST)
FromAlexander Viro <>
SubjectRe: 2.4.15-pre9 breakage (inode.c)

On Sat, 24 Nov 2001, Andrea Arcangeli wrote:

> and it's slower and overlay complex compared to the right fix:

> --- 2.4.15aa1/fs/ext2/super.c.~1~	Fri Nov 23 08:21:00 2001
> +++ 2.4.15aa1/fs/ext2/super.c	Sat Nov 24 07:50:19 2001
> @@ -643,6 +643,7 @@
>  			printk(KERN_ERR "EXT2-fs: corrupt root inode, run e2fsck\n");
>  		} else
>  			printk(KERN_ERR "EXT2-fs: get root inode failed\n");
> +		invalidate_inodes(sb);
>  		goto failed_mount2;
>  	}
>  	ext2_setup_super (sb, es, sb->s_flags & MS_RDONLY);


	It also fixes the problem for good for all filesystems.  As
for the speed - see previous posting.  It _is_ noise.  Comparison
with zero, test bit and two not taken branches.  In final iput().

	Seriously, check what else happens on that path.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:13    [from the cache]
©2003-2008