Messages in this thread | | | Subject | Re: [PATCH] fix compile warnings in 2.4.15pre9 | From | Robert Love <> | Date | 22 Nov 2001 19:03:03 -0500 |
| |
On Thu, 2001-11-22 at 18:54, Andreas Dilger wrote: > How about something like (not real patches, but you get the idea: > > @@ -4691,6 +4691,7 @@ > OUTL_DSP (SCRIPTA_BA (np, clrack)); > +out_stuck: > return; > -out_stuck: > } > > @@ -5226,6 +5227,7 @@ > > +fail: > return; > -fail: > }
Yes, much better. Besides looking better, gcc _may_ generate different code (I don't know how smart it is in this case) that has these "fall throughs" and that would mean (a) less code and (b) less jumps -- always a win.
Robert Love
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |