Messages in this thread | | | Date | Wed, 21 Nov 2001 11:16:15 +0000 | From | Tim Waugh <> | Subject | Re: [BUG] Bad #define, nonportable C, missing {} |
| |
On Wed, Nov 21, 2001 at 12:40:17PM +0000, vda wrote:
> drivers/block/paride/pf.c: if (l==0x20) j--; targ[j]=0; > drivers/block/paride/pg.c: if (l==0x20) j--; targ[j]=0; > drivers/block/paride/pt.c: if (l==0x20) j--; targ[j]=0; > (these files need Lindenting too) > ---------- > Missing {} > Either a bug or a very bad style (so bad that I can even imagine > that it is NOT a bug). Please double check before applying the patch!
This seems to be just bad indentation rather than a bug. 'targ[j]=0' seems to have the purpose of zero-terminating the string, if you look at the callers of those functions. (But yes, the code is extremely hard to read, and I can't convince myself either way about whether the || two lines earlier should or shouldn't be an &&.)
Tim. */ [unhandled content-type:application/pgp-signature] | |