Messages in this thread | | | Date | Thu, 15 Nov 2001 21:41:16 +0100 (CET) | From | Gérard Roudier <> | Subject | Re: [PATCH] small sym-2 fix |
| |
On Thu, 15 Nov 2001, David S. Miller wrote:
> From: Gérard Roudier <groudier@free.fr> > Date: Thu, 15 Nov 2001 20:46:34 +0100 (CET) > > diff -u ../sym-2-orig/sym_glue.h ./sym_glue.h > --- ../sym-2-orig/sym_glue.h Thu Nov 15 22:53:34 2001 > +++ ./sym_glue.h Thu Nov 15 23:18:58 2001 > @@ -77,7 +77,6 @@ > #include <linux/errno.h> > #include <linux/pci.h> > #include <linux/string.h> > -#include <linux/malloc.h> > #include <linux/mm.h> > #include <linux/ioport.h> > #include <linux/time.h> > > Hmmm, why not add linux/slab.h? It exists in every Linux kernel tree > your driver would ever be compiled under.
Just because the driver has its own allocator as you know and thus does not need this header (it didn't need malloc.h too).
Gérard.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |