![]() | |||||||||||||
Messages in this thread |
"David S. Miller" wrote: > From: Till Immanuel Patzschke <tip@internetwork-ag.de> > Date: Tue, 13 Nov 2001 22:30:24 +0100 > > I've attached a patch, checking for headroom first, and - if necessary - > reallocating a larger buffer for the skb_push. > > Please check and apply - or find a better fix! > > Here is my "better fix". In pppoatm, we should be increasing the > device header length appropriately. ie. dev->hard_header_len needs to > be increased in the pppoatm driver when vc-encaps is used. that is - of course - a more pppoatm specific fix BUT my concern ist that PPP requires (!) to have at least 2 bytes headroom [when using PPP_FILTER] (which is NOT noted), and isn't it good practice to check for room before claiming it? -- Till Immanuel Patzschke mailto: tip@internetwork-ag.de interNetwork AG Phone: +49-(0)611-1731-121 Bierstadter Str. 7 Fax: +49-(0)611-1731-31 D-65189 Wiesbaden Web: http://www.internetwork-ag.de - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | ||||||||||||
| Last update: 2005-03-22 12:13 [from the cache] ©2003-2008 | |||||||||||||