Messages in this thread | | | Date | Mon, 12 Nov 2001 09:40:16 +0100 (CET) | From | Kai Germaschewski <> | Subject | Re: [PATCH] save sound mixer state over suspend |
| |
On Mon, 12 Nov 2001, Jeff Garzik wrote:
> As we mentioned on IRC, ymfpci uses ac97_codec, which does not contain > the ac97_reset function.
Being curious: Which IRC channel? - I checked the #kernelnewbies log, but that's apparently not it.
> > I cannot test the patch because my suspend/resume cycle > > retains mixer levels without it (2.2.14 stock, PCG-Z505JE), > > so I would not see any difference.
Interesting. My notebook is pretty much the European variant (PCG-Z600NE), but it doesn't retain the mixer levels.
> The patch looks ok, but I wonder about the order in ymfpci_resume. You > load the mixer values -then- call ymfpci_download_image and > ymfpci_memload. It seems for the purposes of general sanity and > stability you would want to load the mixer values after doing those two > operations.
Okay. I figured the ac97 codec and programming the chip itself wouldn't interfere, but I agree that it looks saner to have the ac97_restore_state at a later point. I'll change the patch accordingly.
--Kai
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |